Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added onPhoneNumberFocus handler #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ucozlab
Copy link

@ucozlab ucozlab commented Oct 28, 2018

I need to make some actions in my app on every input focus, so could you pls add the "onFocus" handler? Thanks!

@tomegz
Copy link
Contributor

tomegz commented Dec 16, 2018

Have you tried passing onFocus with inputProps?

@ucozlab
Copy link
Author

ucozlab commented Dec 17, 2018 via email

@nazarlitvin
Copy link

Hi guys, do you need any help with this PR? It would be great to have onFocus handler!

@ucozlab
Copy link
Author

ucozlab commented May 7, 2019

yes, I need @tomegz to check why the tests are failed and approve this PR

@Tomlgls
Copy link

Tomlgls commented May 15, 2019

+1

@tomegz
Copy link
Contributor

tomegz commented May 15, 2019

You should first resolve the conflicts and make your branch up to date. Maybe the tests will stop failing then. Also, looking through the code it seems really weird that it doesn't work for you if you pass it like this:

const inputProps = {
  onFocus: yourOnFocusHandler,
};

<IntlTelInput inputProps={inputProps} />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants