Fully delegate canonicalisation to cmdstanr #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look good, I would only bump cmdstanr to 0.5.0 as that is the first version with the |
Oh good catch, thanks! |
|
Thank you! Is this PR ready to be merged from your side? |
Yep! This is compatible with the current |
|
Perfect! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Stan model canonicalisation process to be fully delegated to
cmdstanr, rather than manually callingstanc. This is to allow for compatibility with the new WSL functionality incmdstanr, (which is unfortunately not currently compatible withbrmsdue to the manualstanccall)Let me know if I can add any other clarifications/changes here!
Cheers,
Andrew