Remove spaces before primary constructor

Closes pinterest#1207
paul-dingemans · Aug 9, 2021 · ccb2047 · ccb2047
1 parent 946283e
commit ccb2047
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/...standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/SpacingAroundParensRule.kt b/...standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/SpacingAroundParensRule.kt
@@ -7,6 +7,7 @@ import com.pinterest.ktlint.core.ast.ElementType.FUNCTION_TYPE
 import com.pinterest.ktlint.core.ast.ElementType.IDENTIFIER
 import com.pinterest.ktlint.core.ast.ElementType.KDOC_START
 import com.pinterest.ktlint.core.ast.ElementType.LPAR
+import com.pinterest.ktlint.core.ast.ElementType.PRIMARY_CONSTRUCTOR
 import com.pinterest.ktlint.core.ast.ElementType.RPAR
 import com.pinterest.ktlint.core.ast.ElementType.SUPER_KEYWORD
 import com.pinterest.ktlint.core.ast.ElementType.VALUE_ARGUMENT_LIST
@@ -38,7 +39,8 @@ class SpacingAroundParensRule : Rule("paren-spacing") {
                             // val foo: @Composable () -> Unit
                             node.treeParent?.treeParent?.elementType != FUNCTION_TYPE ||
                             // Super keyword needs special-casing
-                            prevLeaf.prevLeaf()?.elementType == SUPER_KEYWORD
+                            prevLeaf.prevLeaf()?.elementType == SUPER_KEYWORD ||
+                            prevLeaf.prevLeaf()?.treeParent?.elementType == PRIMARY_CONSTRUCTOR
                         ) &&
                     (
                         node.treeParent?.elementType == VALUE_PARAMETER_LIST ||

diff --git a/...dard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/SpacingAroundParensRuleTest.kt b/...dard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/SpacingAroundParensRuleTest.kt
@@ -1,5 +1,6 @@
 package com.pinterest.ktlint.ruleset.standard
 
+import com.pinterest.ktlint.core.LintError
 import com.pinterest.ktlint.test.diffFileFormat
 import com.pinterest.ktlint.test.diffFileLint
 import com.pinterest.ktlint.test.format
@@ -89,4 +90,39 @@ class SpacingAroundParensRuleTest {
             """.trimIndent()
         assertThat(SpacingAroundParensRule().format(code)).isEqualTo(code)
     }
+
+    @Test
+    fun `lint trailing spaces after constructor`() {
+        val code =
+            """
+            class SomeClass constructor ()
+
+            """.trimIndent()
+
+        val actual = SpacingAroundParensRule().lint(code)
+
+        assertThat(actual)
+            .isEqualTo(
+                listOf(
+                    LintError(1, 28, "paren-spacing", """Unexpected spacing before "(""""),
+                )
+            )
+    }
+
+    @Test
+    fun `format trailing spaces after constructor`() {
+        val code =
+            """
+            class SomeClass constructor ()
+            """.trimIndent()
+
+        val actual = SpacingAroundParensRule().format(code)
+
+        assertThat(actual)
+            .isEqualTo(
+                """
+                class SomeClass constructor()
+                """.trimIndent()
+            )
+    }
 }