Refactor SaxHandler for clarity #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String.new creates a string with an encoding of ASCII-8BIT which was causing the elements to also have that encoding. This change uses a duplicate of the string provided from Nokogiri, which is in the correct encoding, as the buffer for the element's value.
The overall goal was to make the code easier to grok while I was tracking down the issue with elements having the wrong encoding. * Tried to reduce the number of instances of respond_to? in the code by pulling common uses of it out to methods. * The parse stack is now composed of simple objects instead of it being an array of arrays. * Now using an identifier for an empty buffer instead of empty string. * Cleaned up several variables that were not being used. * Encapsulated @stack so it's not being exposed as part of the API. * #cdata_block is now an alias instead of delegating to characters.
ezkl
added a commit
that referenced
this pull request
Jun 4, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall goal was to make the code easier to grok while I was
tracking down the issue with elements having the wrong encoding.
This includes and depends on issue #31, sorry for any duplication.