You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The obvious issue here is that Cython 3 aligns division semantics with Python 3, so x / y always produces a Python float even where x and y are both Python integers. This could be rewritten as x // y to produce an integer.
I could offer a PR for the particular cases showing up in the test failures, but it might be best for someone more familiar with the code to review uses of the / operator throughout the various .pyx files.
The text was updated successfully, but these errors were encountered:
Hi @musicinmybrain, thanks for the report - the only offending division operations are in the unit tests. I'm hoping to have a new release out today, with fixes for this and for #126.
Cython 3.0.0 was released, and
indexed_gzip
is not quite compatible.The obvious issue here is that Cython 3 aligns division semantics with Python 3, so
x / y
always produces a Pythonfloat
even wherex
andy
are both Python integers. This could be rewritten asx // y
to produce an integer.I could offer a PR for the particular cases showing up in the test failures, but it might be best for someone more familiar with the code to review uses of the
/
operator throughout the various.pyx
files.The text was updated successfully, but these errors were encountered: