-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support index creation for unseekable file objects #103
Conversation
Hi @epicfaace, would you be able to clarify your use case (in code)? I'm guessing your code looks something like this?
The CI failures are on the py27 jobs - it looks like
|
@epicfaace Hmm, your unit test is not actually triggering the There are a few other changes that would be required in order to make this work - one option (possibly the simplest) would be to pass the compressed size at creation, so that the |
I've pushed a couple of commits with my proposal to pass in |
@pauldmccarthy thanks for looking into this! Yes, the code block you wrote is essentially how I'm using it, though I'm interfacing with ratarmount. In my use case, I'm essentially gzip-streaming a file and want to export an index from that stream, so I don't in fact know the compressed size in advance. However, it looks like the only time Also, if it's helpful, see here for more context on my complete use case! mxmlnkn/ratarmount#95 (comment) |
@pauldmccarthy Actually, this PR as is should serve my purposes. Even though I don't know the compressed size of the file in advance, I can just pass in a dummy value (such as |
1 similar comment
@pauldmccarthy Actually, this PR as is should serve my purposes. Even though I don't know the compressed size of the file in advance, I can just pass in a dummy value (such as |
Hi @epicfaace, sorry for the delay, I've not found the time to look at this again. So have you tested that you can build an index from a stream, by passing a dummy non-0 value for the compressed size? The compressed size is used in a few locations (do a grep for |
@epicfaace You've tagged the wrong username. @pauldmccarthy is the name you meant to tag. Can you remove me from this conversation please? |
@paulmccarthy sorry! You will need to click "Unsubscribe" to remove yourself from the conversation. |
Not yet! |
Moved this over to #105 |
closing in favor of #105 |
Fixes #102.