MNT: Raise FileNotFoundError on non-existent path #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exist - this is for consistency with the GzipFile class
…tream code assumes a ValueError is raised
pauldmccarthy
force-pushed
the
mnt/filenotfound
branch
from
d232bd9
to
a4b06cb
Compare
pauldmccarthy
force-pushed
the
mnt/filenotfound
branch
from
a4b06cb
to
52f6794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
IndexedGzipFileclass to raise aFileNotFoundErrorrather than aValueError, when passed a path to a non-existent file. This change is made to improve consistency with thegzip.GzipFileclass.To preserve compatibility, a custom error type is raised - this type sub-classes both
FileNotFoundErrorandValueError.