Strong name for VroomJs assembly #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll push a NuGet update this evening, when I get out of work. |
|
Hey @pauldotknopf! Is it possible to push this update to NuGet? Thanks! 😄 |
|
Oops, sorry, brain-fart, it is pushed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to switch ReactJS.NET from using its embedded version of VroomJs to instead using your fork. Currently, all the ReactJS.NET assemblies are strong named - This was mainly to support enterprise-ish environments where the websites use strong names (and thus all dependencies must also use a strong name). This diffs adds a strong name for the VroomJs assembly.