Customizable project name detection process #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add predefined resolvers for Projectile and Magit.
The invocation of the callback would crash because of a wrong number of arguments, which would never let the system know that a bucket was created, wasting CPU time on constantly resending requests for bucket creation.
|
Hi @VojtechStep Thank you very much for tackling this issue, I quite like the multiple resolvers architecture. With this in place I believe the package has a good level of adaptability to one's workflow. I'll ping issues #7 and #8 to ask for more feedback after this feature is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
This PR allows the user to specify multiple ways of detecting the name of the project. I have included multiple resolvers based on Projectile and Magit, as those are the primary tools I use for interacting with project structures. I believe the process for adding custom resolvers is easy and reasonably documented.
I also removed projectile from dependencies, as it is now an optional dependency and the package works fine without it installed.
There was also one error I found in the implementation of a request callback, which may have affected performance, so it would probably be good to ping the issues about slowing down Emacs and ask whether this patch changes anything.
Let me know if there is anything missing.