This repository has been archived by the owner on Jun 12, 2020. It is now read-only.
Minor fixes for installation and custom user handling #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
reviewed
Jun 1, 2018
tasks/install.yml
Outdated
| dest: '{{ restic_install_path }}/restic' | ||
| mode: '0750' | ||
| owner: 'root' | ||
| owner: '{{ restic_user }}' |
There was a problem hiding this comment.
Using root as a binary owner is a security feature.
Intention behind using root as an owner and setting mode to 0750 was that a user running restic command would be able to run it when he is in the restic_group group, but he won't be allowed to modify it.
Why did you change it? It doesn't work or there is some another issue?
There was a problem hiding this comment.
ah, my bad! I somehow misread the mode and thought 5 was r+w whereas it's r+x -- it's much better how it was, I will ditch the second commit then! :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change introduces
restic_versionfor handling file name in/tmp/. This will allow upgrades and downgrades ofresticclient in environments that are not constantly restarting/reloading/cleaning up (Ansible Tower in our case).Second change enforces
restic_uservariable on the installedresticclient. I think this actually wouldn't work should you specify any different user in the variable as there's '0750' mode on the file, which would lack the executable bit for the group (that was set properly viarestic_group).