Nbformat.current is deprecated

[gabraganca]

This fix the warning that is thrown when runipy is loaded.

The version of the notebook changed to 4 with IPython 3.0.0. The format of the previous notebook and this new one is different. When the user is using IPython 3.0, runipy will load the notebook as version 3 and not 4. I think this PR can help on this.

[gabraganca]

It still need to be tested on IPython < 3.0. I think it will not work because it will not find the read and write functions of nbformat.

[gabraganca]

It is not passing the tests on IPython 2.x series.

Traceback (most recent call last):
  File "test.py", line 68, in testRunNotebooks
    self.assert_notebooks_equal(expected, runner.nb)
  File "test.py", line 49, in assert_notebooks_equal
    self.assertEquals(a, e)
AssertionError: {'output_type': u'pyout', 'prompt_number': 2, 'text': u'<IPython.core.display.SV [truncated]... != {u'output_type': u'pyout', u'prompt_number': 2, u'text': u'<IPython.core.display [truncated]...
- {'output_type': u'pyout',
+ {u'output_type': u'pyout',
?  +

-  'prompt_number': 2,
+  u'prompt_number': 2,
?  +

-  'svg': u'<svg height="100" width="100">\n    <circle cx="50" cy="50" fill="red" r="40" stroke="black" stroke-width="2"/>\n</svg>',
+  u'svg': u'<svg height="100" width="100">\n    <circle cx="50" cy="50" fill="red" r="40" stroke="black" stroke-width="2"/>\n</svg>',
?  +

-  'text': u'<IPython.core.display.SVG objecta90>'}
?                                            ---

+  u'text': u'<IPython.core.display.SVG object>'}
?  +

[gabraganca]

About the error I mentioned above, I get the same thing when testing the master branch. So it could be some problem in my computer.

Checking the error output again, it seems related to some strings been tagged as unicode.

[gabraganca]

If #54 is true, may this is not neccessary anymore....

[jakirkham]

Could you please rebase these changes on the current master?

[gabraganca]

@jakirkham done.

Please note that it still does not support version 4 of the notebooks.

[jakirkham]

Thanks @gabraganca. Also, thanks for fixing up the tests. This looks generally good to me. I'll take a closer look later. I made a couple of minor comments.

[gabraganca]

@jakirkham you're welcome. I just checked your comments and made the changes.

[gabraganca]

@jakirkham If you are deprecating IPython 2.0 (#78), maybe it would be better to not accept this PR. What do you think?

[jakirkham]

Should be an int. ( https://ipython.org/ipython-doc/3/api/generated/IPython.nbformat.html#IPython.nbformat.reads ) Probably good to be consistent, as well.

[jakirkham]

I see your point, @gabraganca. However, I think this is a harmless enough change that I am in favor of it.

Though I do favor deprecating an old and no longer actively maintained version of iPython. If there are runipy users on iPython 2, I would like to hear from them first. Admittedly, iPython has gone through a number of breaking changes in a relatively short window compared to other projects of similar reach. So, if there is still a user base that benefits from this functionality, I wouldn't be completely surprised.

[jakirkham]

...and it's in. Thanks again @gabraganca.

[jakirkham]

Fixes https://github.com/paulgb/runipy/issues/56.

[gabraganca]

👍

Thanks.