Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Consider Wunderbar #161

Merged
merged 3 commits into from
Mar 30, 2018

Conversation

gribnoysup
Copy link
Contributor

A follow-up to #157 (comment)

Feel free to close it if you are not convinced 😸

@pedro93 pedro93 mentioned this pull request Mar 24, 2018
@denar90 denar90 changed the base branch from master to version-4 March 28, 2018 20:03
@denar90
Copy link
Collaborator

denar90 commented Mar 28, 2018

I've created new branch version-4 and change base. This one can be merged If noone against of this solution :)

@gribnoysup
Copy link
Contributor Author

gribnoysup commented Mar 28, 2018

@denar90 perfect timing, haha! I just pushed a few smallish updates:

  • Windows compat issues are resolved in the Wunderbar; Bumped dependency version
  • Removed charm library from dependencies list: it is not used anywhere in the PWMetrics anymore
  • Updated yarn.lock file; Completely missed it the first time 😅

@pedro93
Copy link
Collaborator

pedro93 commented Mar 28, 2018

One question: After this is merged what version will pwmetrics bump to? It should be a minor version right? No breaking functionality was introduced right?

@denar90
Copy link
Collaborator

denar90 commented Mar 29, 2018

It isn't breaking change, but what I wanted is more cool stuff in version 4. Not just LH update, it will be boring for users. If we present LH update, wunderbar and others then it will be more attractive, at list I think...

@paulirish
Copy link
Owner

TBH I don't know if pwmetrics gets a lot of new benefit out of LH 3.0. So it does seem reasonable to do a minor release with the wunderbar stuff.

@denar90 denar90 changed the base branch from version-4 to master March 30, 2018 19:24
@denar90 denar90 merged commit f871579 into paulirish:master Mar 30, 2018
@denar90
Copy link
Collaborator

denar90 commented Mar 30, 2018

Merged 💥 @gribnoysup thanks for your effort 💪

@denar90 denar90 mentioned this pull request Mar 30, 2018
@gribnoysup
Copy link
Contributor Author

Yay! Thank you all! I'm glad I could be of any help to this project 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants