fix: exit code is 1 when expectations are not fulfilled

[GuillaumeAmat]

Fix #193

A bit of refact of the start method, in order to return 1 as the exit code when expectations have errors.

[GuillaumeAmat]

@denar90 My PR is working well as you can see. The Travis job is failing due to the set expectations ^^

Can I raise them a bit?

[denar90]

Hi @GuillaumeAmat. The reason we don't fail when expectations haven't met because users might run several pages in one process. If the first page fails, the process will exit and other pages will be skipped.
You will be able to handle this stuff manually in your code when #188 will be done.

[GuillaumeAmat]

Oh, I understand. But as #188 helps to fill the gap, it not makes it easier to achieve :/

In my use case, all my pages are tested concurrently in parallel CI jobs. It is more efficient IMHO. But anyway, an easy way to fail the CI would be much appreciated.

What about a new option? Eg: --fail-on-error

[denar90]

Oh, I see. --fail-on-error will be nice to have. Good idea!

[GuillaumeAmat]

Done :)

[GuillaumeAmat]

@denar90 Do you know when you (or someone else) will be able to merge it (if it is ok) and release it?

[denar90]

I'll look at it later today)

…

On Fri, Oct 12, 2018, 9:00 PM Guillaume AMAT ***@***.***> wrote: @denar90 <https://github.com/denar90> Do you know when you (or someone else) will be able to merge it (if it is ok) and release it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#194 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF8V3B8SOqMSk02wwd8INz1W15Cb8ZAKks5ukNjGgaJpZM4XVNw3> .

[denar90]

Published 💥

[GuillaumeAmat]

Thanks! 🤗

[sejoker]

exactly what I needed, thanks for landing this.

[GuillaumeAmat]

You're welcome @sejoker ;)