Close RTCPeerConnection objects before deleting #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps the Chromium garbage collection system clean up resources. If we don't do this, and we create and destroy too many instances, we get this error: Uncaught DOMException: Failed to construct 'RTCPeerConnection': Cannot create so many PeerConnections Note that there is a separate bug with Chromium that has existed for 5+ years. The bug is that garbage collection does not get triggered at all for lots of deleted RTCPeerConnections: https://bugs.chromium.org/p/chromium/issues/detail?id=825576 People have worked around this Chromium bug using queueMicrotask(). That correctly works around the issue, but only if the RTCPeerConnection was closed before deleting.
golgirihm
force-pushed
the
close_rtcpeerconnections_before_deleting
branch
from
fc66d4f to
4ade96f
Compare
paullouisageneau
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps the Chromium garbage collection system clean up resources. If we don't do this, and we create and destroy too many instances, we get this error: Uncaught DOMException: Failed to construct 'RTCPeerConnection': Cannot create so many PeerConnections
Note that there is a separate bug with Chromium that has existed for 5+ years. The bug is that garbage collection does not get triggered at all for lots of deleted RTCPeerConnections: https://bugs.chromium.org/p/chromium/issues/detail?id=825576
People have worked around this Chromium bug using queueMicrotask(). That correctly works around the issue, but only if the RTCPeerConnection was closed before deleting.