-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add H.265 packetizer and related codec selection #932
Add H.265 packetizer and related codec selection #932
Conversation
This PR adds H265 packetization according to RFC 7798 RTP Payload Format Implementation. Our plan is to integrate in OBS so it can be used with the nvenc h265 encoder which provides awesome quality. We are testing/validating the PR with the fixed H265 support Safari as per WebKit/WebKit#15494 @paullouisageneau could you review this and provide us feedback of any change that may be required for merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, thank you for the contribution! I've just a few comments about duplicated code which could be made common with the h264 packetizer.
89e84bc
to
de460c2
Compare
@paullouisageneau Thank you for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, it looks good overall. Don't worry about #929, I'll add this to the refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…rivate-separator Fix H264RtpPacketizer::Separator made private by #932
No description provided.