Support custom ICE ufrag and pwd fields via config #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to enable setting a pre-shared ufrag/pwd as part of implementing libp2p WebRTC-Direct.
|
Apologies in advance if I've made some basic errors - C is not my forte though I've tried to add a test.. |
achingbrain
added a commit
to achingbrain/libdatachannel
that referenced
this pull request
Jun 5, 2024
Adds two new optional config keys - `iceUfrag` and `icePwd` which are passed to libjuice. Depends on paullouisageneau/libjuice#249
achingbrain
added a commit
to achingbrain/libdatachannel
that referenced
this pull request
Jun 5, 2024
Adds two new optional config keys - `iceUfrag` and `icePwd` which are passed to libjuice. Depends on: paullouisageneau/libjuice#249 Refs: paullouisageneau#1166
achingbrain
added a commit
to achingbrain/libdatachannel
that referenced
this pull request
Jun 5, 2024
Adds two new optional config keys - `iceUfrag` and `icePwd` which are passed to libjuice. Depends on: paullouisageneau/libjuice#249 Refs: paullouisageneau#1166
|
Very true! Not enough coffee, sorry.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable setting a pre-shared ufrag/pwd as part of implementing libp2p WebRTC-Direct.
Refs: paullouisageneau/libdatachannel#1166