-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array.prototype.find is always shimmed #433
Labels
Comments
That's not entirely accurate - we want to shim if it reaches the iteration of index 1 - but you're correct that this seems wrong, because of the I'll get a fix out for this shortly. |
(note that this isn't breaking anything, it's just needlessly shimming) |
ljharb
added a commit
to paulmillr/Array.prototype.find
that referenced
this issue
Jan 23, 2017
Published as v0.35.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I believe this will shim find if the behaviour of find is correct.
[, 1].find(function (item, idx) { return idx === 0; })
should returnundefined
(assuming my understanding that[, 1]
should act the same as[undefined, 1]
, so we want to shim if it returns1
. This means the negation is placed incorrectly.The text was updated successfully, but these errors were encountered: