Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Uncaught (in promise) TypeError' in Chrome 48 #408

Merged
merged 1 commit into from
Feb 9, 2016
Merged

Fix 'Uncaught (in promise) TypeError' in Chrome 48 #408

merged 1 commit into from
Feb 9, 2016

Conversation

mcmath
Copy link
Contributor

@mcmath mcmath commented Feb 9, 2016

Fix for Issue #407.

On Chrome 48.0 in OSX, the following console warning started appearing with the release of es6-shim v0.34.3:

Uncaught (in promise) TypeError: object is not a function            index.html:1
    at Object.defer (native)
    at chain (native)
    at then (native)

The one-line change here fixes the warning. It seems that the warning was originating from the 'inner' promise p (the promise resolved by the 'outer' promise p2) on line 2562. The fix was to catch the rejection by promise p with a noop.

The warning is gone and all tests are passing.

@ljharb
Copy link
Collaborator

ljharb commented Feb 9, 2016

This is super bonkers but I can confirm it fixes it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants