Fix 'Uncaught (in promise) TypeError' in Chrome 48 #408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #407.
On Chrome 48.0 in OSX, the following console warning started appearing with the release of es6-shim v0.34.3:
The one-line change here fixes the warning. It seems that the warning was originating from the 'inner' promise
p
(the promise resolved by the 'outer' promisep2
) on line 2562. The fix was to catch the rejection by promisep
with a noop.The warning is gone and all tests are passing.