-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] migrate tests to Github Actions #469
Conversation
|
I'm very confused why the PR isn't triggering an actions run :-/ it's running on my fork: https://github.com/ljharb/es6-shim/runs/2470213815 |
@paulmillr is there an "approve and run" button showing for you on the PR status box? |
@ljharb I think it will only show after the merge |
That has not been my experience - pull_request_target workflows behave like that, but most of these are pull_request, and should work immediately. You can see all the hundreds of PRs I linked to ljharb/object.assign#81 running on the first PR. |
perhaps it depends on repo owner, which is different in your repos. let's try merging it, we can always revert |
I'd prefer to hold off; I'm pinging github folks about it: https://git.luolix.topmunity/t/pr-adding-actions-not-running-jobs/177497 I'll land the PR once they confirm it's a bug, or working as intended, but they might need the PR left open to debug it. |
Figured it out; I had to land at least one action in the default branch first to "enable" actions (which seems like a clear bug). I'll land this once the tests pass. |
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
=========================================
Coverage ? 86.05%
=========================================
Files ? 2
Lines ? 2352
Branches ? 607
=========================================
Hits ? 2024
Misses ? 328
Partials ? 0 Continue to review full report at Codecov.
|
Per ljharb/object.assign#81