cryptoNode: fall back to Node.js crypto when webcrypto not available #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
legobeat
commented
Aug 30, 2024
| @@ -1,7 +1,9 @@ | |||
| // We use WebCrypto aka globalThis.crypto, which exists in browsers and node.js 16+. | |||
| // We prefer WebCrypto aka globalThis.crypto, which exists in node.js 16+. | |||
There was a problem hiding this comment.
Removed the mention of browsers, as those are importing from crypto.ts and should not be arriving here AIUI
legobeat
force-pushed
the
crypto-node-compat
branch
from
c311875 to
6d3aa0a
Compare
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Node.js v14 does have a built-in
node:cryptowith the requiredrandomBytes, it is not exported undercrypto.webcrypto. This adds a fallback to use the built-incryptowhenwebcryptois not available.