Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve typing for readdirpPromise #199

Merged
merged 1 commit into from
Sep 17, 2024
Merged

improve typing for readdirpPromise #199

merged 1 commit into from
Sep 17, 2024

Conversation

yuheiy
Copy link
Contributor

@yuheiy yuheiy commented Sep 17, 2024

Currently, the type of return value of readdirpPromise is Promise<unknown>. I fixed the type to Promise<string[]>.

@paulmillr paulmillr merged commit 24cdcdb into paulmillr:master Sep 17, 2024
3 checks passed
@KillerCodeMonkey
Copy link
Contributor

but the type should be Promise<EntityInfo[]>, right?

@paulmillr
Copy link
Owner

Likely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuheiy @KillerCodeMonkey @paulmillr