Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to version 114 #5

Merged
merged 3 commits into from
Jun 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
config:
- {
name: "Windows 32",
os: "windows-2019",
os: "windows-2022",
target: "windows",
cef_platform: "windows32",
vs_arch: "Win32",
Expand All @@ -26,7 +26,7 @@ jobs:
}
- {
name: "Windows 64",
os: "windows-2019",
os: "windows-2022",
target: "windows",
cef_platform: "windows64",
vs_arch: "x64",
Expand All @@ -35,7 +35,7 @@ jobs:
}
- {
name: "Windows ARM 64",
os: "windows-2019",
os: "windows-2022",
target: "windows",
cef_platform: "windowsarm64",
vs_arch: "ARM64",
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ project("MyApp")

# CEF configuration
set_property(GLOBAL PROPERTY OS_FOLDERS ON)
set(CEF_VERSION "111.2.7+gebf5d6a+chromium-111.0.5563.148")
set(CEF_VERSION "114.2.10+g398e3c3+chromium-114.0.5735.110")

# Determine the platform
if(NOT DEFINED CEF_PLATFORM)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ You can download a compiled version for your system on releases page or actions

You can change CEF_VERSION variable inside CMakeLists.txt.

Example of valid version: `111.2.7+gebf5d6a+chromium-111.0.5563.148`.
Example of valid version: `114.2.10+g398e3c3+chromium-114.0.5735.110`.

Visit https://cef-builds.spotifycdn.com/index.html for the list of supported platforms and versions.

Expand Down
5 changes: 0 additions & 5 deletions app/src/shared/windows/Entrypoint.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ namespace shared
// entry point function for all processes
int APIENTRY wWinMain(HINSTANCE hInstance)
{
// enable High-DPI support on Windows 7 or newer on version less than 112
#if CEF_VERSION_MAJOR < 112
CefEnableHighDPISupport();
#endif

void *sandboxInfo = nullptr;

#if defined(CEF_USE_SANDBOX)
Expand Down