Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed off-by-one error #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed off-by-one error #3

wants to merge 2 commits into from

Commits on Nov 29, 2018

  1. Fixed off-by-one error 

    Always zero out the whole 40 byte buffer of stringin and transmit only
39 bytes if requested length is 40. This way we make sure that the
resulting string is always null terminated even if the PLC sends a
non-terminated one. It also means that the effective maximum string
length is 39.
    @krisztianloki
    krisztianloki committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    cfcfd44 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Merge branch 'master' of https://github.com/paulscherrerinstitute/s7plc

    @krisztianloki
    krisztianloki committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    5dc9768 View commit details
    Browse the repository at this point in the history