Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HICTK_UNREACHABLE_CODE macro with hictk::unreachable_code() #285

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

robomics
Copy link
Contributor

[no ci]

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.29%. Comparing base (5e298f6) to head (ece59da).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/libhictk/hic/include/hictk/hic/common.hpp 0.00% 1 Missing ⚠️
...k/hic/include/hictk/hic/impl/block_reader_impl.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   79.04%   79.29%   +0.25%     
==========================================
  Files         171      173       +2     
  Lines       16327    16995     +668     
  Branches     2251     2309      +58     
==========================================
+ Hits        12906    13477     +571     
- Misses       2454     2514      +60     
- Partials      967     1004      +37     
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/285/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 69.75% <33.33%> (+0.19%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/285/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 77.31% <33.33%> (+0.88%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit b5ad66b into main Oct 10, 2024
120 of 122 checks passed
@robomics robomics deleted the maintenance/refactor branch October 10, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant