Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hictk: support replaying warnings right before app exit #313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Bugfix

cec303a
Select commit
Loading
Failed to load commit list.
Open

hictk: support replaying warnings right before app exit #313

Bugfix
cec303a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 0s

77.54% (+0.00%) compared to da6732a

View this Pull Request on Codecov

77.54% (+0.00%) compared to da6732a

Details

Codecov Report

Attention: Patch coverage is 61.34969% with 63 lines in your changes missing coverage. Please review.

Project coverage is 77.54%. Comparing base (da6732a) to head (cec303a).

Files with missing lines Patch % Lines
src/hictk/main.cpp 66.20% 40 Missing and 9 partials ⚠️
src/hictk/cli/cli_fix_mcool.cpp 0.00% 5 Missing ⚠️
src/hictk/cli/cli_dump.cpp 0.00% 4 Missing ⚠️
src/hictk/cli/cli.cpp 50.00% 2 Missing and 1 partial ⚠️
src/hictk/cli/cli_load.cpp 0.00% 1 Missing ⚠️
src/hictk/cli/cli_zoomify.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   77.54%   77.54%           
=======================================
  Files         173      173           
  Lines       21225    21319   +94     
  Branches     2310     2315    +5     
=======================================
+ Hits        16458    16532   +74     
- Misses       3756     3779   +23     
+ Partials     1011     1008    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.