Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: query mirroring #43

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Bugfix: query mirroring #43

merged 5 commits into from
Apr 16, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Apr 16, 2024 •
edited
Loading

Fix two bugs that could sometimes be triggered when fetching subsets of cis matrices in dense matrix format.

@robomics
Bugfix
a2f4f3b 
Fix bug that led to incorrect query mirroring of asymmetric cis queries
sharing the same start position but where the second end position is
greater than the first one.
@robomics
Bugfix
c2e0d4f 
Fix out of bound access that could occur when satisfying asymmetric cis
queries parially overlapping with the matrix diagonal.
@robomics
Add more tests
58158f3
@robomics
Do not rely on uint overflows
6daa144
@robomics
Bugfix
aa3d8a5
@robomics robomics merged commit 6ca1ee2 into main Apr 16, 2024
13 checks passed
@robomics robomics deleted the fix/query-mirroring branch April 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robomics