Don't send the same parameters in query string and JWT for redirect U…

…RL (erlef#360)
paulswartz · Jul 26, 2024 · 3b0b522 · 3b0b522
1 parent cbd19a8
commit 3b0b522
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 9 deletions.
diff --git a/src/oidcc_authorization.erl b/src/oidcc_authorization.erl
@@ -448,9 +448,6 @@ essential_params(QueryParams) ->
     lists:filter(
         fun
             ({<<"scope">>, _Value}) -> true;
-            ({<<"response_type">>, _Value}) -> true;
-            ({<<"client_id">>, _Value}) -> true;
-            ({<<"redirect_uri">>, _Value}) -> true;
             (_Other) -> false
         end,
         QueryParams

diff --git a/test/oidcc_authorization_SUITE.erl b/test/oidcc_authorization_SUITE.erl
@@ -44,9 +44,6 @@ create_redirect_url_inl_gov(_Config) ->
 
     ?assertMatch(
         #{
-            <<"client_id">> := <<"client_id">>,
-            <<"redirect_uri">> := <<"https://my.server/return">>,
-            <<"response_type">> := <<"code">>,
             <<"scope">> := <<"openid">>,
             <<"request">> := _
         },

diff --git a/test/oidcc_authorization_test.erl b/test/oidcc_authorization_test.erl
@@ -211,9 +211,6 @@ create_redirect_url_with_request_object_test() ->
 
     ?assertMatch(
         #{
-            <<"client_id">> := <<"client_id">>,
-            <<"redirect_uri">> := <<"https://my.server/return">>,
-            <<"response_type">> := <<"code">>,
             <<"scope">> := <<"openid">>,
             <<"should_be_in">> := <<"both">>,
             <<"request">> := _