Fix deb/ar.go: Read() may return less bytes. Also fix trailing slashes. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultag
reviewed
May 29, 2019
deb/ar.go
Outdated
| } | ||
| if count != 60 { | ||
| if pos < 60 { |
There was a problem hiding this comment.
Can this code be implemented by using an io.LimitReader and ioutils.ReadAll?
paultag
reviewed
May 29, 2019
deb/ar.go
Outdated
| } | ||
| if string(header) != "!<arch>\n" { | ||
| return fmt.Errorf("Header doesn't look right!") | ||
| return fmt.Errorf("Header doesn't look as 'ar' file.") |
There was a problem hiding this comment.
The english here is a bit broken - maybe Header is invalid for an 'ar' archive. instead?
|
A few comments on the PR here; thanks for your patches! |
|
I guess it is now more readable (with LimitedReader as you suggested). I also added simple test to be sure that new implementation also works. This test revelaed that FileMode parsing was wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO read is allowed to be short and return less bytes than requested. Also add suport for trailing slashes (#59).