Add wlan tuning #312
Merged
Add wlan tuning #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
virtualguy
commented
Feb 26, 2023
virtualguy
commented
- proxy_arp
- bss_transition
- fast_roaming_enabled
joshuaspence
requested changes
Feb 28, 2023
docs/resources/wlan.md
Outdated
| @@ -62,6 +62,8 @@ resource "unifi_wlan" "wifi" { | |||
| ### Optional | |||
|
|
|||
| - `ap_group_ids` (Set of String) IDs of the AP groups to use for this network. | |||
| - `bss_transition` (Boolean) Enable BSS Transition Defaults to `false`. | |||
There was a problem hiding this comment.
Add a period to the description
docs/resources/wlan.md
Outdated
| @@ -62,6 +62,8 @@ resource "unifi_wlan" "wifi" { | |||
| ### Optional | |||
|
|
|||
| - `ap_group_ids` (Set of String) IDs of the AP groups to use for this network. | |||
| - `bss_transition` (Boolean) Enable BSS Transition Defaults to `false`. | |||
| - `fast_roaming_enabled` (Boolean) Enable Fast Roaming Defaults to `false`. | |||
docs/resources/wlan.md
Outdated
| @@ -75,6 +77,7 @@ resource "unifi_wlan" "wifi" { | |||
| - `no2ghz_oui` (Boolean) Connect high performance clients to 5 GHz only Defaults to `true`. | |||
| - `passphrase` (String, Sensitive) The passphrase for the network, this is only required if `security` is not set to `open`. | |||
| - `pmf_mode` (String) Enable Protected Management Frames. This cannot be disabled if using WPA 3. Valid values are `required`, `optional` and `disabled`. Defaults to `disabled`. | |||
| - `proxy_arp` (Boolean) Enable Proxy ARP Defaults to `false`. | |||
go.mod
Outdated
| @@ -1,4 +1,4 @@ | |||
| module github.com/paultyng/terraform-provider-unifi | |||
| module github.com/virtualguy/terraform-provider-unifi | |||
internal/provider/resource_wlan.go
Outdated
| Description: "BSS Transition", | ||
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| Default: false, |
There was a problem hiding this comment.
This should default to true to match the UI
| { | ||
| Config: testAccWLANConfig_proxy_arp(subnet, vlan), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| // testCheckNetworkExists(t, "name"), |
There was a problem hiding this comment.
You're not actually checking anything here
* proxy_arp * bss_transition * fast_roaming_enabled
joshuaspence
force-pushed
the
feat/add-wlan-proxy-arp-bss-transition-fast-roaming
branch
from
789736e
to
5012f34
Compare
joshuaspence
approved these changes
Mar 10, 2023
virtualguy
deleted the
feat/add-wlan-proxy-arp-bss-transition-fast-roaming
branch
|
Thanks for the clean up @joshuaspence much appreciated |
No problem, I wanted to use these changes myself! Thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.