Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the device retry timeouts #322

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Lower the device retry timeouts #322

merged 4 commits into from
Mar 1, 2023

Conversation

joshuaspence
Copy link
Collaborator

No description provided.

@joshuaspence
Copy link
Collaborator Author

Running the tests locally a bunch of times and recording the timings:

Create

1.412811044s
3.035877179s
3.037758325s
3.044741674s
3.050418837s
6.214741785s
6.215806489s
6.216325084s
6.218168262s
6.218225455s
6.218772658s
6.219159452s
6.234406609s
12.622599966s
12.623312322s
12.62510037s
12.64417478s
12.647050943s
12.650366232s
12.653716915s
12.660444871s
12.664156084s
12.669007809s
12.674815836s
12.704902325s
22.624527013s
32.644355773s
32.731798437s
42.639981034s

Update

NOTE: I suspect these timings are so low because the demo devices don't do anything in provisioning.

1.779696ms
1.78012ms
1.795582ms
1.899986ms
2.204318ms
2.292564ms
2.296648ms
2.362805ms
2.423109ms
2.438252ms
2.815912ms
2.882351ms
2.88313ms
3.181476ms
3.546344ms
3.94022ms
4.01936ms
4.370908ms
4.420317ms
4.894348ms
5.081625ms
5.147152ms
5.539233ms
5.676538ms
5.816508ms
5.867277ms
5.962067ms
6.020225ms
6.394296ms
7.109636ms
7.297068ms
7.606683ms
7.626584ms
7.940588ms
8.027254ms
8.089646ms
8.450739ms
8.49077ms
9.315915ms
9.539166ms
10.002768ms
10.860104ms
11.729118ms
12.272797ms
13.521851ms
16.057406ms
16.291257ms
18.263428ms

Delete

12.643902545s
12.649001326s
12.651601728s
12.675765539s
22.619699685s
22.622992456s
22.624582539s
22.626957126s
22.630012656s
22.631354983s
22.632146824s
22.632839985s
22.63526811s
22.636798175s
22.637908842s
22.641177383s
22.641374031s
22.64237258s
22.644309028s
22.646352345s
22.651677791s
22.654081696s
22.655274763s
22.664375321s
22.666310361s
22.669189613s
22.670890062s
22.67790073s

@joshuaspence joshuaspence merged commit 450ce18 into main Mar 1, 2023
@joshuaspence joshuaspence deleted the retry branch March 1, 2023 02:04
joshuaspence added a commit to chrishas35/terraform-provider-unifi that referenced this pull request Mar 1, 2023
* Lower the device retry timeouts

* Add debug logging

* Revert "Add debug logging"

This reverts commit 209da04dd9cee2e826724f27ea4602cdc9414015.

* Tweak timeouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant