Add parity scale codec #547

Gauthamastro · 2022-09-06T07:32:23Z

PR adds support of parity-scale-codec for rust-decimal.

References

paupino

Thank you for your contribution! Sorry it's taken a while to look at this. Life - yada yada.

A couple of changes requested as well as the need to run makers format to pass compilation.

src/decimal.rs

Cargo.toml

paupino · 2022-10-06T15:56:20Z

src/decimal.rs

@@ -124,6 +128,10 @@ pub struct UnpackedDecimal {
    archive_attr(derive(Clone, Copy, Debug))
 )]
 #[cfg_attr(feature = "rkyv-safe", archive_attr(derive(CheckBytes)))]
+#[cfg_attr(
+feature = "scale-codec",
+derive(Decode, Encode, TypeInfo, MaxEncodedLen),


Side note (no change required): these derive attributes are causing a bit of code bloat. I want to rethink how we do this in v2. It may be by exposing a wrapper struct and aliasing it however all in all, this current approach isn't entirely scalable.

Gauthamastro · 2023-06-22T02:11:31Z

@paupino I got busy with my work and lost this PR through the cracks. We use your library extensively, I would be great if we can merge this PR; I will fix your comments soon.

paupino

Sorry it's taken a little while to review this!

Added a few changes as suggestions in the PR to make it a little easier.
One thing I noticed: there is no test covering this or documentation for this feature.

As an example PR for adding a test and docs, please see this: https://github.com/paupino/rust-decimal/pull/583/files

Almost there!

paupino · 2023-07-10T15:30:12Z

Cargo.toml

@@ -78,6 +81,7 @@ rkyv = ["dep:rkyv"]
 rkyv-safe = ["dep:bytecheck", "rkyv/validation"]
 rocket-traits = ["dep:rocket"]
 rust-fuzz = ["dep:arbitrary"]
+scale-codec =  ["parity-scale-codec-derive","parity-scale-codec","scale-info"]


We're starting to use the updated format for feature dependencies:

Suggested change

scale-codec = ["parity-scale-codec-derive","parity-scale-codec","scale-info"]

scale-codec = ["dep:parity-scale-codec-derive","dep:parity-scale-codec","dep:scale-info"]

paupino · 2023-07-10T15:31:18Z

Cargo.toml

@@ -86,7 +90,7 @@ serde-str = ["serde-with-str"]
 serde-with-arbitrary-precision = ["serde", "serde_json/arbitrary_precision", "serde_json/std"]
 serde-with-float = ["serde"]
 serde-with-str = ["serde"]
-std = ["arrayvec/std", "borsh?/std", "bytecheck?/std", "byteorder?/std", "bytes?/std", "rand?/std", "rkyv?/std", "serde?/std", "serde_json?/std"]
+std = ["arrayvec/std", "borsh?/std", "bytecheck?/std", "byteorder?/std", "bytes?/std", "rand?/std", "rkyv?/std", "serde?/std", "serde_json?/std", "parity-scale-codec?/std","scale-info?/std"]


Just a simple reordering of inclusions:

Suggested change

std = ["arrayvec/std", "borsh?/std", "bytecheck?/std", "byteorder?/std", "bytes?/std", "rand?/std", "rkyv?/std", "serde?/std", "serde_json?/std", "parity-scale-codec?/std","scale-info?/std"]

std = ["arrayvec/std", "borsh?/std", "bytecheck?/std", "byteorder?/std", "bytes?/std", "parity-scale-codec?/std", "rand?/std", "rkyv?/std", "scale-info?/std", "serde?/std", "serde_json?/std"]

paupino · 2023-07-10T15:31:49Z

src/decimal.rs

@@ -120,6 +124,11 @@ pub struct UnpackedDecimal {
    archive(compare(PartialEq)),
    archive_attr(derive(Clone, Copy, Debug))
 )]
+#[cfg_attr(feature = "rkyv-safe", archive_attr(derive(CheckBytes)))]


This is duplicated below

Suggested change

#[cfg_attr(feature = "rkyv-safe", archive_attr(derive(CheckBytes)))]

paupino · 2023-07-10T15:32:47Z

src/decimal.rs

+#[cfg_attr(
+feature = "scale-codec",
+derive(Decode, Encode, TypeInfo, MaxEncodedLen),
+)]


This will fix the code formatting error in the build:

Suggested change

#[cfg_attr(

feature = "scale-codec",

derive(Decode, Encode, TypeInfo, MaxEncodedLen),

)]

#[cfg_attr(feature = "scale-codec", derive(Decode, Encode, TypeInfo, MaxEncodedLen))]

paupino · 2023-07-10T15:33:03Z

src/decimal.rs

@@ -548,7 +557,7 @@ impl Decimal {
    }

    #[must_use]
-    pub(crate) const fn from_parts_raw(lo: u32, mid: u32, hi: u32, flags: u32) -> Decimal {
+    pub const fn from_parts_raw(lo: u32, mid: u32, hi: u32, flags: u32) -> Decimal {


Reverting this line:

Suggested change

pub const fn from_parts_raw(lo: u32, mid: u32, hi: u32, flags: u32) -> Decimal {

pub(crate) const fn from_parts_raw(lo: u32, mid: u32, hi: u32, flags: u32) -> Decimal {

* Added clippy configurations in .cargo/config.toml * clippy --fix * cargo clippy --fix -- -W clippy::uninlined_format_args

…o#600)

…aupino#619) * Fixes issue whereby scale 29 is required however is optimized away * Disable test for legacy ops

* Update to 1.1 borsh * Fixes Borsh upgrade --------- Co-authored-by: John Barker <dev@j16r.net>

Co-authored-by: Paul Mason <paul@paulmason.me>

…paupino#625) * Fixes precision issue with to_f64 with some numbers without fractions * Sign should not be applied to early for to_f64

…e bit (paupino#628)

Co-authored-by: Paul Mason <paul@paulmason.me>

* Reimplement checked_powu. * Add pow tests. * Add short-cuts to powu. * Fix x.powu(0) * Refine powu implementation. * Exclude a failing test that was caused by the deprecated legacy-ops feature --------- Co-authored-by: Paul Mason <paul@paulmason.me>

…ino#636) * Fixes error handling when second decimal place at tail position * Added further bounds tests

* Version 1.34 * Corrected version in readme file

…pino#643)

# Conflicts: # Cargo.toml # src/decimal.rs

Gauthamastro added 4 commits September 6, 2022 13:01

Add parity scale codec

27c62bc

Add scale-info too

394d8f8

Add scale-info too

204d127

Make from_parts_raw

610096f

paupino requested changes Oct 6, 2022

View reviewed changes

Merge branch 'master' into master

b896337

Make deps in alphabetical order

25f0849

Gauthamastro requested a review from paupino June 22, 2023 02:18

paupino requested changes Jul 10, 2023

View reviewed changes

mkatychev and others added 20 commits July 16, 2023 23:39

Clippy/fix ruleset (paupino#598)

031d203

* Added clippy configurations in .cargo/config.toml * clippy --fix * cargo clippy --fix -- -W clippy::uninlined_format_args

Fixes issue with truncating implicitly rounding in some cases (paupin…

deeb242

…o#600)

added new rkyv (paupino#597)

091d715

Version 1.31.0 (paupino#601)

67efda9

Specify version on macro dependency

29d3e2e

Drop unnecessary byteorder dependency (paupino#603)

a6d5caf

Fixes issue with is_integer failing on decimal bounds (paupino#605)

951512d

Version 1.32 (paupino#606)

03ce442

Introduce breaking change check (paupino#608)

f18e57c

Remove semver checks from build and put into makefile (paupino#609)

aacdefd

Fixes issue whereby scale 29 is required however is optimized away (p…

1686b69

…aupino#619) * Fixes issue whereby scale 29 is required however is optimized away * Disable test for legacy ops

Upgrade Borsh to resolve vulnerability (paupino#621)

ede308d

* Update to 1.1 borsh * Fixes Borsh upgrade --------- Co-authored-by: John Barker <dev@j16r.net>

deserializes empty string into None Option (paupino#607)

6cfccf3

Co-authored-by: Paul Mason <paul@paulmason.me>

Version 1.33.0 (paupino#622)

1c80137

Fixes precision issue with to_f64 with some numbers without fractions (…

c3802db

…paupino#625) * Fixes precision issue with to_f64 with some numbers without fractions * Sign should not be applied to early for to_f64

Version 1.33.1 (paupino#626)

c4d4d3e

Introduces macros feature and cleans up serde documentation a littl…

829355a

…e bit (paupino#628)

Update readme to add comparisons (paupino#630)

f02f5ac

Remove cargo-edit reference from README (paupino#633)

d323dd4

Auto-document feature guarded items (paupino#634)

10ee2ee

Co-authored-by: Paul Mason <paul@paulmason.me>

schungx and others added 13 commits January 13, 2024 09:26

Fixes error handling when second decimal place at tail position (paup…

aa2c3d3

…ino#636) * Fixes error handling when second decimal place at tail position * Added further bounds tests

Version 1.34 (paupino#640)

bacc60b

* Version 1.34 * Corrected version in readme file

Force version number during macro resolution (paupino#642)

999bb02

Rollback macros feature flag due to dependency resolution issues (pau…

179039a

…pino#643)

Bump macros version

d72e787

Add parity scale codec

4666555

Add scale-info too

65ec77a

Add scale-info too

e7511dc

Make from_parts_raw

62cf912

Make deps in alphabetical order

d778de7

Merge remote-tracking branch 'origin/master'

bbcc77a

# Conflicts: # Cargo.toml # src/decimal.rs

Update hashbrown

e1b54cd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add parity scale codec #547

Add parity scale codec #547

Gauthamastro commented Sep 6, 2022

paupino left a comment

paupino Oct 6, 2022

Gauthamastro commented Jun 22, 2023

paupino left a comment

paupino Jul 10, 2023

paupino Jul 10, 2023

paupino Jul 10, 2023

paupino Jul 10, 2023

paupino Jul 10, 2023

	scale-codec = ["parity-scale-codec-derive","parity-scale-codec","scale-info"]
	scale-codec = ["dep:parity-scale-codec-derive","dep:parity-scale-codec","dep:scale-info"]

	std = ["arrayvec/std", "borsh?/std", "bytecheck?/std", "byteorder?/std", "bytes?/std", "rand?/std", "rkyv?/std", "serde?/std", "serde_json?/std", "parity-scale-codec?/std","scale-info?/std"]
	std = ["arrayvec/std", "borsh?/std", "bytecheck?/std", "byteorder?/std", "bytes?/std", "parity-scale-codec?/std", "rand?/std", "rkyv?/std", "scale-info?/std", "serde?/std", "serde_json?/std"]

	pub const fn from_parts_raw(lo: u32, mid: u32, hi: u32, flags: u32) -> Decimal {
	pub(crate) const fn from_parts_raw(lo: u32, mid: u32, hi: u32, flags: u32) -> Decimal {

Add parity scale codec #547

Are you sure you want to change the base?

Add parity scale codec #547

Conversation

Gauthamastro commented Sep 6, 2022

paupino left a comment

Choose a reason for hiding this comment

paupino Oct 6, 2022

Choose a reason for hiding this comment

Gauthamastro commented Jun 22, 2023

paupino left a comment

Choose a reason for hiding this comment

paupino Jul 10, 2023

Choose a reason for hiding this comment

paupino Jul 10, 2023

Choose a reason for hiding this comment

paupino Jul 10, 2023

Choose a reason for hiding this comment

paupino Jul 10, 2023

Choose a reason for hiding this comment

paupino Jul 10, 2023

Choose a reason for hiding this comment