Allow write() to print non-string objects #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebageek
force-pushed
the
make-write-print-non-string-objects
branch
from
84ae048
to
347fad0
Compare
|
Hi @sebageek Thanks for the PR! |
pavdmyt
requested changes
Feb 12, 2021
Allow write() to print anything that is not a string by converting it via str(), just like the builtin print() does. Fixes pavdmyt#34
sebageek
force-pushed
the
make-write-print-non-string-objects
branch
from
347fad0
to
f566d85
Compare
pavdmyt
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow write() to print anything that is not a string by converting it
via str(), just like the builtin print() does.
Fixes #34
This version does not do any
*argsfoo just to behave exactly like print. I have found it useful though to just trow any object I currently have into print and have yaspin printig, whatever that may be.In PR #37 I took a bit of a different approach for converting the
textargument to string, but I find it to be more concise this way. If there are plans to drop python2 support somewhen in the future this could also be made a lot simpler.And, as always, I'm open to discussing this. :)