Fix hidden context manager exception handling #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an exception is raised inside the exception block we need to make sure that the hidden level/unhide logic is executed regardless.
hartwork
approved these changes
Aug 16, 2020
pavdmyt
requested changes
Aug 18, 2020
pavdmyt
approved these changes
Aug 19, 2020
|
Seems there is a broken test under pypy2 in recent build: https://travis-ci.org/github/pavdmyt/yaspin/jobs/719239699 |
|
Included in v1.1.0, also available at PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exception is raised inside the exception block we need to make
sure that the hidden level/unhide logic is executed regardless.
I showed #68 to @hartwork and he asked why I'm not using a try-finally construct. He has a point. ;)