Wait of stop event instead of sleep. #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavdmyt
approved these changes
Dec 16, 2020
|
Hi @eerimoq Thanks for the PR! It will be included into the next release. |
|
Great :D |
Closed
|
Included in yaspin 1.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my script one spinner is shown per build step. The first time a step takes a few seconds, and the spinner overhead is negligible. However, the next time steps ends almost instantly, and the spinner overhead of about one interval per spinner, in my case n * 80 ms, which is actually quite irritating. This PR waits on the stop condition instead of sleeping, which makes the spinner finish immediately.