-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to write elapsed time at the end of the line #99
Conversation
harenbrs
commented
Dec 15, 2020
•
edited
Loading
edited
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 95.11% 95.35% +0.24%
==========================================
Files 6 6
Lines 307 323 +16
==========================================
+ Hits 292 308 +16
Misses 15 15
Continue to review full report at Codecov.
|
Hi @harenbrs Thanks for your PR! |
Sure thing, done—let me know if they're not up to snuff. |
@pavdmyt I can't reproduce this test failure in a Python 2.7 environment:
I don't see how my PR could cause the failure, either, when all other versions pass. I'm adding an empty commit to run the check again. |
Hi @pavdmyt, happy new year -- are you happy enough with the tests and CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally everything looks good 👍
There are some minor items that should be addressed before merging. Please let me know if some additional help / clarifications needed.
Co-authored-by: Pavel Dmytrenko <pavdmyt@aiven.io>
@harenbrs Thanks again for your contribution! Will be included into next release. |
Included in yaspin v1.4.0 |