Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and bug fix #4

Merged
merged 17 commits into from
Apr 6, 2018
Merged

Update and bug fix #4

merged 17 commits into from
Apr 6, 2018

Conversation

mbtaylor1982
Copy link
Collaborator

@mbtaylor1982 mbtaylor1982 commented Mar 9, 2018

1 Update to TZDB 2018C

2 Added Docs generated with PasDoc.. (still needs work)

3 Fixed a bug where GetDisplayName was returning both the std and dst names separated with a slash if it was '/' separated in the Zone FOTMAT column in the TZDB files.

FROM IANA TZDB:

The FORMAT column specifies the usual abbreviation of the time zone name. It can have one of three forms:

a string of three or more characters that are either ASCII alphanumerics, “+”, or “-”, in which case that’s the abbreviation
a pair of strings separated by a slash (‘/’), in which case the first string is the abbreviation for the standard time name and the second string is the abbreviation for the daylight saving time name
a string containing “%s,” in which case the “%s” will be replaced by the text in the appropriate Rule’s LETTER column

4 Fixed and updated Testcases

miket and others added 15 commits March 2, 2018 14:18
…009: ETestFailure

TZDB data had been updated but the test case had not.
2) Added Test_Europe_London_2018
…st name separated with a slash if it was '/' separated in the zone FOTMAT column in the TZDB files.

FROM IANA TZDB:

The FORMAT column specifies the usual abbreviation of the time zone name. It can have one of three forms:

a string of three or more characters that are either ASCII alphanumerics, “+”, or “-”, in which case that’s the abbreviation
a pair of strings separated by a slash (‘/’), in which case the first string is the abbreviation for the standard time name and the second string is the abbreviation for the daylight saving time name
a string containing “%s,” in which case the “%s” will be replaced by the text in the appropriate Rule’s LETTER column

Also updated and fixed remaining test case bugs.
@pavkam pavkam self-requested a review March 12, 2018 19:29
@pavkam pavkam self-assigned this Mar 12, 2018
@pavkam
Copy link
Owner

pavkam commented Mar 12, 2018

Hi Michael,

Thanks for the updates! I have not had a valid Delphi version for years now.
Let me know when you're done so I can verify and commit the changes.

Thanks,
Alex.

miket added 2 commits March 13, 2018 18:26
… the TZDB specified them in local time. The code now provides correct daylight saving information for many previously broken north American time zones.
@pavkam pavkam merged commit 491ead2 into pavkam:master Apr 6, 2018
@pavkam
Copy link
Owner

pavkam commented Apr 6, 2018

Thanks, I have merged it in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants