fixed overflow issue for x86 archs #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlo-v-chernykh
requested changes
Feb 13, 2018
There was a problem hiding this comment.
Hi @Pirayya , could you make fixes according to comments and I'll merge it then.
Let's make it a little bit sexier 😉
encoder.go
Outdated
| @@ -98,7 +98,7 @@ func (kse *keyStoreEncoder) writeCertificate(cert *Certificate) error { | |||
| return err | |||
| } | |||
| certLen := len(cert.Content) | |||
There was a problem hiding this comment.
I think wrapping uint64(len(cert.Content)) would be enough.
Could you fix it and I'll merge it then.
encoder.go
Outdated
| @@ -150,7 +150,7 @@ func (kse *keyStoreEncoder) writePrivateKeyEntry(alias string, pke *PrivateKeyEn | |||
| return err | |||
| } | |||
| privKeyLen := len(encodedPrivKeyContent) | |||
encoder.go
Outdated
| @@ -162,7 +162,7 @@ func (kse *keyStoreEncoder) writePrivateKeyEntry(alias string, pke *PrivateKeyEn | |||
| return err | |||
| } | |||
| certCount := len(pke.CertChain) | |||
|
Thanks @pavel-v-chernykh for the quick check! Much sexier fix 😄, I updated the branch with a new commit which should be more satisfactory! I forced push, sorry for that! |
|
@Pirayya , thanks for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7
Not the most sexy fix but will take two memory slots on x86 and the conversion in 64bit arch int to uint64 should not overflow