Add Azure Container Apps as a host option (#1952) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update bicep for ACA * First working version * Support workload profile * Add support for CORS and fix identity for openai * Add aca-host * Make acr unique * Add doc for aca host * Update ACA docs * Remove unneeded bicep files * Revert chanes to infra/main.parameters.json * Fix markdown lint issues * Run frontend build before building docker image * remove symlinks and update scripts with paths relative to its own folder instead of cwd * Merge with main.bicep * output AZURE_CONTAINER_REGISTRY_ENDPOINT * Fix deployment with app service * Improve naming and README * Fix identity name and cost esitmation for aca * Share env vars in bicep and update docs * Revert "remove symlinks and update scripts with paths relative to its own folder instead of cwd" This reverts commit 40287f2. * Add containerapps as a commented out host option * Update app/backend/.dockerignore * Apply suggestions from code review * More steps for deployment guide * Update azure.yaml * Update comment * cleanup bicep files and improve docs * Update condition for running in production for credential * Update ManagedIdentityCredential to use UAMI for containerapps --------- Co-authored-by: Pamela Fox <pamela.fox@gmail.com> Co-authored-by: Pamela Fox <pamelafox@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update bicep for ACA
First working version
Support workload profile
Add support for CORS and fix identity for openai
Add aca-host
Make acr unique
Add doc for aca host
Update ACA docs
Remove unneeded bicep files
Revert chanes to infra/main.parameters.json
Fix markdown lint issues
Run frontend build before building docker image
remove symlinks and update scripts with paths relative to its own folder instead of cwd
Merge with main.bicep
output AZURE_CONTAINER_REGISTRY_ENDPOINT
Fix deployment with app service
Improve naming and README
Fix identity name and cost esitmation for aca
Share env vars in bicep and update docs
Revert "remove symlinks and update scripts with paths relative to its own folder instead of cwd"
This reverts commit 40287f2.
Add containerapps as a commented out host option
Update app/backend/.dockerignore
Apply suggestions from code review
More steps for deployment guide
Update azure.yaml
Update comment
cleanup bicep files and improve docs
Update condition for running in production for credential
Update ManagedIdentityCredential to use UAMI for containerapps