-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config from pyproject.toml
or .git-changelogrc
#54
Comments
Could you elaborate a bit? Do you want to allow declaring a custom convention in YAML/TOML? I'd advise against that. I actually tried to implement such a thing in the past, and unfortunately declarative languages will never be enough. You'll hit incompatibilities in how (multi)line strings are handled between Python and TOML, especially for regular expressions. Well, that's only my experience, so of course if you manage to code something elegant and powerful, I'll review it. But I would very much not like to maintain a super complex configuration trying to code complex logic in TOML. I'd prefer some hook system to easily create a custom convention in Python directly. If I misunderstood your intentions, let me know! And if you just meant (for now) to have a config file for the current options, I'm OK with that! Lets go with TOML, reading from Thanks for your contributions! 🚀 |
Yes, it would be a two-step process. First, just cover the current CLI options and after that, on a separate effort, deal with the complex configurations. Thanks for the list of files 👍 I'm currently finishing up a PR :) |
Permit *git-changelog* be configured permanently via config files. Resolves: pawamoy#54.
Permit *git-changelog* be configured permanently via config files. Resolves: pawamoy#54.
Permit *git-changelog* be configured permanently via config files. Resolves: pawamoy#54.
Permit *git-changelog* be configured permanently via config files. Resolves: pawamoy#54.
Permit *git-changelog* be configured permanently via config files. Resolves: pawamoy#54.
Is your feature request related to a problem? Please describe.
Allow permanent configuration through either of those files.
Describe the solution you'd like
Permit customizing execution by writing permanent configs on some project's file.
Describe alternatives you've considered
Makefile, storing the command line on a text file?
Additional context
In attempting an implementation for #48, it seemed easier to write the modifications to the code convention as a toml / yaml dictionary. Once that way of writing the modifications is implemented, we could move on to creating a language for the CLI.
The text was updated successfully, but these errors were encountered: