Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change obnoxious header to minimal header #557

Open
wants to merge 4 commits into
base: 5.x
Choose a base branch
from

Conversation

Se8870
Copy link

@Se8870 Se8870 commented Nov 19, 2021

When someone uses #define YSI_NO_OBNOXIOUS_HEADER, show minimal header.

The reason why i push this? is because this is important especially if you're using YSI with SAFE_STARTUP.
I believe doing this will "decrease" lag, plus this header is important for letting people know that you are using YSI.

When someone uses #define YSI_NO_OBNOXIOUS_HEADER, show minimal header.

The reason why i push this? is because this is important especially if you're using YSI with SAFE_STARTUP.
I believe doing this will "decrease" lag, plus this header is important for letting people know that you are using YSI.
@Se8870
Copy link
Author

Se8870 commented Nov 19, 2021

One thing to note, i'm changing YSI_gsObnoxiousHeader with YSI_gsTitleHeader to avoid declaring two unused variable.
Thus, YSI_gsTitleHeader is a good "universal" name.

I've been discussing this with Y_Less and decided to remove Obnoxious Header for good, because keeping it will resulting many people to complain again.
@Se8870 Se8870 changed the title Add minimal header Change obnoxious header to minimal header Nov 19, 2021
@Y-Less
Copy link
Member

Y-Less commented Nov 21, 2021

Could do with a tiny tweak on spacing, but otherwise looks good.

Also, I didn't align the old version to the centre of a 80-character terminal very well. Maybe that could be done as well (it's 42 characters wide, so left padding of 19 characters).

@Se8870
Copy link
Author

Se8870 commented Nov 21, 2021

Also, I didn't align the old version to the centre of a 80-character terminal very well. Maybe that could be done as well (it's 42 characters wide, so left padding of 19 characters).

What do you mean by this? 🤔
I think it's better to leave it to the left side to match with the server info tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants