-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service endpoint #685
Service endpoint #685
Conversation
paws.common/R/iniutil.R
Outdated
|
||
# Get the profile name from an ini file | ||
found <- grep("^\\[.*\\]", content) | ||
rm_els <- grep("(^;)|(^#)", content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to allow for indented comments, see this beauty of a config file in the wild.
rm_els <- grep("(^;)|(^#)", content) | |
rm_els <- grep("(^;)|(^\\s+#)", content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add it to the test data_ini to make sure it removes them correctly :)
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
==========================================
+ Coverage 84.11% 84.14% +0.02%
==========================================
Files 201 201
Lines 14437 14515 +78
==========================================
+ Hits 12144 12213 +69
- Misses 2293 2302 +9 ☔ View full report in Codecov by Sentry. |
I believe the new test ini file should cater for most scenarios https://github.com/paws-r/paws/blob/7c10b6bfeb99e30974748c36ded79ddc9967ba2b/paws.common/tests/testthat/data_ini When I looked into the package On the bright side the new |
Remove comments before for loop. Addresses issue highlighted in #667