Alternate descriptors not persisted in remote deployments

[dteleguin]

If a WAR is deployed with asadmin in remote mode, and --altdd or --runtimealtdd are used, the alternate descriptors will not be persisted on target domain (opposite to local mode). No $DOMAIN/generated/altdd/* content will be created; upon application reload or server restart, the application will be re-instantiated with standard descriptors from WAR itself.

To reproduce:

asadmin --host=localhost deploy --force --upload=true --altdd=web-alt.xml AltDD.war

Log excerpt:

[2015-08-08T00:24:29.290+0300] [Payara 4.1] [INFO] [AS-WEB-GLUE-00172] [javax.enterprise.web] [tid: _ThreadID=44 _ThreadName=admin-listener(1)] [timeMillis: 1438982669290] [levelValue: 800] [[  Loading application [AltDD] at [/altdd]]]

[2015-08-08T00:24:51.440+0300] [Payara 4.1] [WARNING] [NCLS-COMUTIL-00037] [javax.enterprise.system.util] [tid: _ThreadID=44 _ThreadName=admin-listener(1)] [timeMillis: 1438982691440] [levelValue: 900] [[  Attempt to rename /home/mitya/payara-4.1.153/glassfish/domains/domain1/applications/xfer-5062077237152610881/altdd/web-alt.xml to /home/mitya/payara-4.1.153/glassfish/domains/domain1/generated/altdd/AltDD/web-alt.xml failed after 21 retries]]

[2015-08-08T00:24:51.510+0300] [Payara 4.1] [INFO] [] [javax.enterprise.system.core] [tid: _ThreadID=44 _ThreadName=admin-listener(1)] [timeMillis: 1438982691510] [levelValue: 800] [[  AltDD was successfully deployed in 24 335 milliseconds.]]

This happens because $DOMAIN/generated/altdd/$APP directory is not created before moving the file. The --upload=true key is essential if you deploy to the same machine (otherwise asadmin will simply send absolute file path; in that case everything works fine).

Observed in latest Payara and GlassFish (stable+nightly).

Upstream bug: GLASSFISH-21371