PAYARA-1471-clarify-default-unpack-behaviour #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectory and that this is the default behaviour. Added this fact to the description.
|
Can one of the admins verify this patch? |
|
This is pretty low priority - its debatable whether this is really necessary here, but I think it's helpful. |
|
Also noticed that the unpackdir description wasn't being printed. It looks like it just wasn't found due to a capital letter in the key in the command options. Seems odd, though, because there are other capitals which don't cause an issue. Ideally should be case insensitive, but that's a little more than a 2 minute patch. E: turns out the ones with camelcase are all just error strings |
|
jenkins test please |
smillidge
approved these changes
Feb 20, 2017
|
All tests have passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verified that setting -Djava.io.tmpdir does still change the unpack directory and that this is the default behaviour. Added this fact to the description.