Update grizzly to 2.3.29 and handle gzip/lzma content-encoding of requests PAYARA-1288 PAYARA-1441 #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uests This change updates the grizzly dependency to the 2.3.29. This enables handling of content-encodings for incoming requests by the server. The ability to compress responses has already been part of glassfish, but response handling did not include the ability to handle gzip/lzma compressed requests. This was requested in payara#1038 [2] and also requested for glassfish [0]. Grizzly 2.3.28 gained decompression support[1], but introduced a regression. In this version the incoming datastream was decompressed, but the Content-Encoding header was left in place. This in turn lead to servlet filters/applications to asume the stream was still compressed and triggered a second decompression step [3]. With grizzly 2.3.29 defaults were changed to match 2.3.27 (making request decompression opt-in) and add the ability to remove the problematic header line (opt-in too). The core changes here are: - nucleus/pom.xml: Update grizzly dependecy - nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/GenericGrizzlyListener.java: - Enable removal of content-encodings from the header field, that were handled by the decompression filters - Enable decompression of requests, if compression is enabled - appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/SpdyAddOnProvider.java - ALL_SPDY_VERSIONS is not visible anymore and needs a work-around [0] https://java.net/jira/browse/GLASSFISH-5258 [1] https://java.net/jira/browse/GRIZZLY-1669 [2] payara#1038 [3] payara#1186 [4] https://java.net/jira/browse/GRIZZLY-1875?focusedCommentId=393843&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-393843
|
Can one of the admins verify this patch? |
|
jenkins test please |
|
All tests have passed |
OndroMih
added
the
PR: Awaiting CLA
smillidge
added
PR: CLA
lprimak
approved these changes
Mar 2, 2017
smillidge
changed the title
lprimak
pushed a commit
to flowlogix/Payara
that referenced
this pull request
Jul 5, 2017
…uests (payara#1425) Update grizzly to 2.3.29 and handle gzip/lzma content-encoding of requests PAYARA-1288 PAYARA-1441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the grizzly dependency to the 2.3.29. This enables
handling of content-encodings for incoming requests by the server.
The ability to compress responses has already been part of glassfish,
but response handling did not include the ability to handle gzip/lzma
compressed requests.
This was requested in #1038 [2] and also requested for glassfish [0].
Grizzly 2.3.28 gained decompression support[1], but introduced a
regression. In this version the incoming datastream was decompressed,
but the Content-Encoding header was left in place. This in turn lead
to servlet filters/applications to asume the stream was still
compressed and triggered a second decompression step [3].
With grizzly 2.3.29 defaults were changed to match 2.3.27 (making
request decompression opt-in) and add the ability to remove the
problematic header line (opt-in too).
The changes are:
nucleus/pom.xml:
nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/GenericGrizzlyListener.java:
that were handled by the decompression filters
appserver/grizzly/glassfish-spdy/src/main/java/org/glassfish/grizzly/extras/spdy/SpdyAddOnProvider.java
This is a followup to the support request 229, CLA was send in parallel.
[0] https://java.net/jira/browse/GLASSFISH-5258
[1] https://java.net/jira/browse/GRIZZLY-1669
[2] #1038
[3] #1186
[4] https://java.net/jira/browse/GRIZZLY-1875?focusedCommentId=393843&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-393843