PAYARA-1415 Added test notifiers admin console and command #1620
Conversation
Is both an asadmin command and a button on the admin console. They both work. Third time lucky!
Some coyright corrections as well
|
jenkins test please |
|
Not tested SNMP or Slack notifier working |
|
All tests have passed |
|
jenkins test please |
|
All tests have passed |
| @@ -95,6 +95,7 @@ public void run() { | |||
| pdu.add(new VariableBinding(oidInstance, new OctetString(message.getSubject() + "\n" + message.getMessage()))); | |||
|
|
|||
| snmp.send(pdu, communityTarget); | |||
| logger.log(Level.FINE, "Message sent seuccessfully"); | |||
There was a problem hiding this comment.
seuccessfully -> successfully
| notifier.datadog.configuration.keyLabelHelpText=Datadog key |
|
jenkins test please |
|
One or more tests have failed |
|
Jenkins test please |
|
One or more tests have failed |
There was a problem hiding this comment.
In general, I can tell there is a lot of copy-paste code.
Is there any way to refactor this so it's reusing both UI components and the back-end commands to some common parent class, so this all the notifiers don't look so similar but reuse some core components?
Also, you can use ManagedExecutorService (@Inject it) instead of raw threads
|
jenkins test please |
|
One or more tests have failed |
|
Jenkins, would you kindly? |
|
One or more tests have failed |
|
jenkins test please |
|
All tests have passed |
|
@lprimak No, it can't be refactored as each time it is using different classes that all work in slightly different ways. |
|
Quick build and test failed! |
|
jenkins test please |
|
Quick build and test passed! |
No description provided.