Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-1153 Enable to turn on Weld development mode and the Probe tool #1763

Merged
merged 10 commits into from
Jul 28, 2017
Merged

PAYARA-1153 Enable to turn on Weld development mode and the Probe tool #1763

merged 10 commits into from
Jul 28, 2017

Conversation

jGauravGupta
Copy link
Contributor

@jGauravGupta jGauravGupta commented Jul 13, 2017 •
edited
Loading

Available options to enable Weld Probe tool :

web.xml :

    <context-param>
        <param-name>org.jboss.weld.development</param-name>
        <param-value>true</param-value>
    </context-param>

System Properties :

-Dorg.jboss.weld.development=true

Deploy using console :

asadmin deploy --properties cdiDevModeEnabled=true sample.war

Update using console :

asadmin set applications.application.mavenproject1.property.cdiDevModeEnabled=true

@jGauravGupta
Copy link
Contributor Author

jenkins test please

@payara-ci
Copy link
Contributor

One or more tests have failed

smillidge
smillidge requested changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@smillidge smillidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we call the command line option cdiDevMode just to make it more explicit?

Also can we also add this as a flag in the administration console which can be set during deployment?

@jGauravGupta
Copy link
Contributor Author

Hi @smillidge ,

Just for confirmation, administration console means here a UI (checkbox) option in deployment page.

@smillidge smillidge added this to the Payara 173 milestone Jul 13, 2017
@ggam
Copy link

ggam commented Jul 13, 2017

Great to see this being worked on! This is a killer feature for development stage!

@mulderbaba
Copy link
Contributor

jenkins test please

@payara-ci
Copy link
Contributor

One or more tests have failed

@smillidge
Copy link
Contributor

yeah a checkbox on the deployment page.

@smillidge
Copy link
Contributor

jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@mikecroft
Copy link
Contributor

fixes #1001

ggam
ggam reviewed Jul 24, 2017
View reviewed changes
...rver/admingui/core-l10n/src/main/resources/org/glassfish/admingui/core/Strings_es.properties Outdated
@@ -913,6 +913,8 @@ deploy.deploymentOrder=Orden de Despliegue:
deploy.deploymentOrderHelp=N\u00famero que determina el orden de carga de la aplicaci\u00f3n al iniciar el servidor. Los n\u00fameros inferiores se cargan en primer lugar. El valor por defecto es 100.
deploy.deploymentTime=Tiempo de Despliegue:
deploy.deploymentTimeHelp=El tiempo necesario para desplegar la aplicaci\u00f3n en milisegundos.
deploy.cdiDevMode=Modo de desarrollo de CDI
deploy.cdiDevModeHelp=Permite inspeccionar los componentes del CDI de la aplicaci\u00f3n en tiempo de ejecuci\u00f3n
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better say "componentes de CDI" over "del CDI"

@smillidge
Copy link
Contributor

@jGauravGupta can you resolve @ggam's comment

@jGauravGupta jGauravGupta added the PR: DO NOT MERGE Don't merge PR until further notice label Jul 24, 2017
@smillidge
Copy link
Contributor

jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@jGauravGupta
Copy link
Contributor Author

jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@jGauravGupta
Copy link
Contributor Author

jenkins test please

@jGauravGupta jGauravGupta removed the PR: DO NOT MERGE Don't merge PR until further notice label Jul 27, 2017
@payara-ci
Copy link
Contributor

Quick build and test passed!

@Pandrex247 Pandrex247 merged commit 3f638a8 into payara:master Jul 28, 2017
@jGauravGupta jGauravGupta deleted the PAYARA-1153 branch July 29, 2017 08:02
@payara-ci
Copy link
Contributor

Quick build and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggam ggam ggam left review comments

@smillidge smillidge smillidge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Payara 173
Development

Successfully merging this pull request may close these issues.
8 participants
@jGauravGupta @payara-ci @ggam @mulderbaba @smillidge @mikecroft @fturizo @Pandrex247