PAYARA-1030 Remove Jettison from Payara #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-1030-replace-jettison-with-jackson
They don't always work though.
Propeties of action reports no longer include quotation marks
|
Jenkins test Payara 5 please |
|
Jenkins, quick test Payara 5 please |
|
Quick build and test failed! |
arjantijms
reviewed
Sep 8, 2017
| } | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
Since the body of every case is a return statement, the else is not really needed here. The following would be a bit easier on the eye:
if (BIGDECIMAL.isValue(object)) {
return createValue((BigDecimal) object);
}
if (BIGINTEGER.isValue(object)) {
return createValue((BigInteger) object);
}
arjantijms
reviewed
Sep 8, 2017
| <groupId>org.glassfish</groupId> | ||
| <artifactId>javax.json</artifactId> | ||
| <version>${jsonp.version}</version> | ||
| <type>jar</type> |
There was a problem hiding this comment.
Isn't type jar the default?
arjantijms
reviewed
Sep 8, 2017
| <dependency> | ||
| <groupId>javax.json</groupId> | ||
| <artifactId>javax.json-api</artifactId> | ||
| <version>1.1</version> |
There was a problem hiding this comment.
Better to put these versions at a central place / rely on the managed version
|
Seemingly unrelated failures in quicklook, all file not found ones. E.g. |
|
Jenkins, quick test Payara 5 please |
|
Quick build and test passed! |
|
Jenkins, quick test Payara 5 please |
|
Quick build and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.