PAYARA-2111 Fixed warning in logs from mismatched error page

[michaelranaldo]

Tested with example application and custom application, behaviour remains the same, just without the error page. If a file is provided and configured within Wicket, but cannot be found, then Wicket will throw the error - if a file is correct but incorrectly configured then Payara's behaviour remains the same.

Thanks for @arjantijms and @MattGill98 for the help!

Fixes #1886

[michaelranaldo]

jenkins test please

[payara-ci]

Quick build and test passed!

[smillidge]

Please add the Portions copyright comment...

[michaelranaldo]

Jenkins test please

[payara-ci]

Quick build and test passed!

[arjantijms]

2 extra things to look at:

The pattern is now compared via "glob", but the Servlet patterns are a bit different, namely:

In the Web application deployment descriptor, the following syntax is used to define mappings:

• A string beginning with a ‘/’ character and ending with a ‘/*’ suffix is used for path mapping.
• A string beginning with a ‘*.’ prefix is used as an extension mapping.
• A string containing only the ’/’ character indicates the "default" servlet of the application. In this case the servlet path is the request URI minus the context path and the path info is null.
• All other strings are used for exact matches only.

Internally there should be a specific matcher for this available, as Payara used this too internally to dispatch. From a spec point of view, WebRoleRefPermission on a PermissionCollection does this same kind of match as well. Semi-internally, see also javax.security.jacc.URLPattern.

Another thing that I'm missing is the check on the filter to see if the filter filters the error dispatch. Only those filters should be taken into account for the URL match.

Otherwise, looks good!

[arjantijms]

Discussed this internally and javax.security.jacc.URLPattern seems like the easiest way; idea is to copy this (shade it) to a Payara package, and then create a small utility method, e.g. URLPatternMatcher.match(String pattern1, String pattern2); that instantiates URLPattern with pattern1 and then called implies(pattern2) on it.

[michaelranaldo]

jenkins test please

[payara-ci]

Quick build and test passed!

[michaelranaldo]

jenkins test please

[payara-ci]

Quick build and test passed!

Change request addressed here: 1310659

[arjantijms]

Looks good, thx!