PAYARA-2267 JPA Conversion now unwraps connection properly #2279
Conversation
|
jenkins test please |
| return con; | ||
| public Connection getConnection() throws SQLException { | ||
| //To ensure that the actual connection is always returned and not a proxy | ||
| Connection result = con.unwrap(java.sql.Connection.class); |
There was a problem hiding this comment.
I don't believe blindly unwrapping on getConnection is the correct fix. I think the problem is why unwrap is failing. However I could be wrong.
There was a problem hiding this comment.
Is also missing //Portions Copyright comment
There was a problem hiding this comment.
unwrap was never called, and based on the comment above the method then the actual connection should be returned and not a wrapped version of it.
There was a problem hiding this comment.
unwrap connection is not not used anywhere else in Payara or Eclipselink, unless its done via reflection.
There was a problem hiding this comment.
I also do not believe this is the correct fix.
unwrap() is called by the user to get access to underlying proprietary classes.
Proxy should be returned, not the raw connection here
|
jenkins test please |
|
Quick build and test passed! |
|
@smillidge Is this now okay to be merged? |
No description provided.