PAYARA-2171 Add timeout parameter to start instance command #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
|
Quick build and test passed! |
arjantijms
previously requested changes
Jan 19, 2018
| } catch (InterruptedException e) { | ||
| return Strings.get("start.instance.timeout", instanceName); | ||
| } finally { | ||
| executor.shutdown(); |
There was a problem hiding this comment.
Maybe put the "try" higher up? If executor.schedule throws an exception, the executor might not be shut down.
There was a problem hiding this comment.
Good point, I've moved it higher up
…ing the task fails.
|
jenkins test please |
|
Quick build and test passed! |
Pandrex247
approved these changes
Jan 22, 2018
MattGill98
deleted the
PAYARA-2171-Add-Timeout-Parameter-To-Start-Instance-Command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.